Rates of smoking have declined, fact.
See the chart on this page (click). Yes there will always be smokers, so long as there is tobacco, however rates of smoking were increased for a number of factors that are outside of the individual, including the deceit of tobacco companies, the peer pressure partly informed by the way smoking was advertised (go back and have a look at the old ads if you've forgotten), and the lack of education within society as to exactly how serious the consequences of smoking is.
Since those things have changed, smoking rates have decreased a lot. People who smoke today do so without the pressure of ads that promote smoking, in a context in which tobacco companies are rightly framed as less than upstanding participants in society, and in which there is plenty of education about the consequences.